Fixes changeset being empty when datetime change is sub second #2676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I do not have a local setup with mongo, so I'm sort of using the actions to test.. sorry about that) edit : I just saw that I can enable them in my fork, i'll test there :) |
magnetik
changed the title
alcaeus
approved these changes
Sep 19, 2024
|
if you know how to fix the style issue, feel free to fix it directly there if you want to save some time to restart the checks later ^^ Thanks ! |
|
It goes like this: |
|
Thanks @magnetik! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The ODM was ignoring changes when they are under a second (because of the cast as timestmap).
It might be a BC break because people can rely on the old behavior ?